Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update egui to 0.29 and winit to 0.30 #197

Merged
merged 4 commits into from
Nov 7, 2024
Merged

Update egui to 0.29 and winit to 0.30 #197

merged 4 commits into from
Nov 7, 2024
+30 −33

Conversation

apekros
Copy link
Contributor

@apekros apekros commented Oct 31, 2024 •
edited by kvark
Loading

Fixes #196

winit in 0.30 dropped WindowBuilder in favour of WindowAttributes, so this has be fixed in the examples.

EventLoop::run_app should probably be used instead of deprecated EventLoop::run in examples too

@apekros apekros marked this pull request as ready for review October 31, 2024 03:01
kvark
kvark approved these changes Nov 7, 2024
View reviewed changes
Copy link
Owner

@kvark kvark left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work!

@kvark kvark enabled auto-merge (squash) November 7, 2024 05:32
@kvark kvark merged commit 3622d85 into kvark:main Nov 7, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kvark kvark kvark approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Update to egui 0.29
2 participants
@apekros @kvark